Skip to content

Add serial number translation file for ideal camera#5943

Merged
chkim-usgs merged 6 commits intoDOI-USGS:devfrom
chkim-usgs:ideal_sn
Jan 29, 2026
Merged

Add serial number translation file for ideal camera#5943
chkim-usgs merged 6 commits intoDOI-USGS:devfrom
chkim-usgs:ideal_sn

Conversation

@chkim-usgs
Copy link
Contributor

@chkim-usgs chkim-usgs commented Jan 21, 2026 •
edited
Loading

Description

Adds a serial number translation file for the ideal camera.

Same as the previous PR that was reverted after merge.

Related Issue

Addresses #5662

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@chkim-usgs
Copy link
Contributor Author

chkim-usgs commented Jan 23, 2026

Running into the same hijtter test failures.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Jan 23, 2026

So it seems to be a real error from these changes

@chkim-usgs
Copy link
Contributor Author

chkim-usgs commented Jan 23, 2026

I'm comparing the test cubes: the truth cube has IdealSpacecraft/IdealCamera for SpacecraftName/InstrumentId but the output cube has MARS RECONNAISSANCE ORBITER/HIRISE. It looks like there's something going on in the hijitter process where noproj is being called, still looking into it.

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5943".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@chkim-usgs
Copy link
Contributor Author

chkim-usgs commented Jan 27, 2026

The HIRISE test data for hijitter resulted in serial numbers that were not unique with the format SpacecraftName/InstrumentId/EphemerisTime. I added an optional keyword CcdId to the IdealIdealSerialNumber.trn file that will be used to create a unique serial number if the keyword exists in the cube label so the serial number would look like SpacecraftName/InstrumentId/EphemerisTime/CcdId.

amystamile-usgs
amystamile-usgs approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@amystamile-usgs amystamile-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chkim-usgs chkim-usgs merged commit e6c9f78 into DOI-USGS:dev Jan 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amystamile-usgs amystamile-usgs amystamile-usgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chkim-usgs @Kelvinrr @amystamile-usgs

Comments